Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unitless N_hat added, Float32 tests passing #303

Merged
merged 1 commit into from
Feb 7, 2024
Merged

unitless N_hat added, Float32 tests passing #303

merged 1 commit into from
Feb 7, 2024

Conversation

anastasia-popova
Copy link
Contributor

Purpose

To-do

Content

  • I have read and checked the items on the review checklist.

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c88ba88) 98.74% compared to head (5c70bb0) 98.74%.
Report is 1 commits behind head on main.

❗ Current head 5c70bb0 differs from pull request most recent head 4e03889. Consider uploading reports for the commit 4e03889 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          33       33           
  Lines         874      875    +1     
=======================================
+ Hits          863      864    +1     
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel trontrytel marked this pull request as ready for review February 5, 2024 23:50
@trontrytel trontrytel self-requested a review February 5, 2024 23:50
@trontrytel trontrytel added the P3 label Feb 5, 2024
trontrytel
trontrytel approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - could you also fix the documentation? I think we are incorrectly stating the units of N_0

I can squash/rebase and merge once that is fixed. Thank you!

@trontrytel trontrytel enabled auto-merge February 7, 2024 22:42
@trontrytel trontrytel merged commit 4edb35a into main Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees
No one assigned
Labels
P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anastasia-popova @trontrytel